Refactor: Simplify goal data to use query builder directly #7385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
changed the base branch from
develop
to
epic/time-based-form-goals-GIVE-565
kjohnson
merged commit db868ad
into
epic/time-based-form-goals-GIVE-565
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of supporting new repository methods, this PR simplifies the goal data to use the new
DonationQuerydirectly.Description
I noticed that each update required a check for all-time vs custom and then an additional
*ForDateRange()method. This instantiates the query and conditionally sets the start/end values.Each type of value then completes the query.
GoalType::DONATIONS()calls$query->count().GoalType::DONORS()calls$query->countDonors().GoalType::AMOUNT()calls$query->sumIntendedAmount().