-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update base enum class with forked version from myclabs #7383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, makes sense. Left one very minor suggestion so I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed QA tests
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
Resolves: GIVE-760
Description
We have a php 8.1 incompatibility conflict with the myclabs/php-enum class. Unfortunately we are currently tied to php 7.2 at the moment and cannot update to their latest package that resolves the conflict.
Furthermore, this package is not really maintained anymore since enums were introduced in php 8.1
So for more control over stability and compatibility with GiveWP, this PR forks the base enum class from myclabs including the unit tests and updates our Enum to extend it.
Affects
This technically affects our value objects that extend the enum class, however it's still the same logic with the namespace being our own so the risk is very low.
Visuals
N/A
Testing Instructions
Unit tests and static analysis should take care of the bulk testing. We will want to run through QA regression testing as well.
Pre-review Checklist
@unreleased
tags included in DocBlocks