Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add currency switcher settings to Form Settings #7352

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Feature: add currency switcher settings to Form Settings #7352

merged 1 commit into from
Apr 22, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Apr 15, 2024 •
edited
Loading

Resolves GIVE-664
Blocker for GIVE-640

Description

This pull-request adds the necessary changes to persist Currency Switcher settings being implemented on GIVE-580.

Affects

Form Settings properties

Testing Instructions

Guarantee Form Settings are still being saved as expected when updating a Donation Form in the VFB.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

JoshuaHungDinh
JoshuaHungDinh approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for going over this on the call.

rickalday
rickalday approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@pauloiankoski pauloiankoski merged commit 5da1cc3 into develop Apr 22, 2024
20 checks passed
@pauloiankoski pauloiankoski deleted the feature/add-currency-switcher-settings branch April 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaHungDinh JoshuaHungDinh JoshuaHungDinh approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauloiankoski @rickalday @JoshuaHungDinh