Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add 'schema-find-tour' to onboarding steps #7344

Merged
merged 13 commits into from
Apr 16, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Apr 5, 2024

Resolves GIVE-535

Description

This PR includes this final step to the onboarding flow. Changes include:

  • using the tour object to conditionally render the step from the clickExitTourCallback.
  • adding the new "okay" & "nextVariant" buttons to withButtons object.
  • moving inline-styles from withText object into stylesheet.
  • updating the step count to not include the final "schema-find-tour" step in the withText Object.
  • conditionally including the tour steps in schemaSteps.

This step of the Visual Form Builder (VFB) onboarding process within the build section aims to guide users to easily rediscover the tour. This notice will be displayed only once and is exclusively applicable to the build preview flow (schema-steps). If a user chooses to exit the tour prematurely, the tour will skip to this notice if it has not been viewed before

Additional context:

When the doc page for the VFB is ready an additional step for documentation will be included after the 'schema-find-tour' step.

Affects

VFB onboarding flow for the build section

Visuals

Screen.Recording.2024-04-08.at.11.00.45.AM.mov
Screen.Recording.2024-04-08.at.11.01.07.AM.mov

Testing Instructions

  • Remove givewp-form-builder-schema-tour-completed from userMeta if the flow has already been seen.
  • Start the onboarding flow by visiting the build preview of a form in the VFB
  • The final step should be a green modal advising users where they can find the tour again.
  • You will also need to test that when selecting exit tour from a step if the find tour step has not been seen, it should take the user to that step.
  • Confirm the find tour step only shows while viewing the flow the first time. Once the page has refreshed/changed it should not be seen again.
  • After the the find tour step has been seen, restart the tour & test that exiting the tour works as intended. It should close the tour.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review April 8, 2024 18:16
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Everything seems to work as expected. 👏🏻

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 693c014 into develop Apr 16, 2024
13 of 20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/onboarding-additional-tool-steps branch April 16, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants