Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: form builder sidebar tabs for WP 6.5 compatibility #7343

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Apr 5, 2024

Resolves GIVE-600

Description

The form builder sidebar tabs have been visually compromised after updated to WP 6.5. This PR preserves the backwards compatible styles.

For context, it appears the new version of Gutenberg updated some styles which affected this. To preserve those styles I went back a version to grab what we were relying on and updated our own stylesheet.

Affects

The form builder sidebar tab styles

Visuals

WP 6.5

Screenshot 2024-04-05 at 12 19 02 PM

WP 6.4

Screenshot 2024-04-05 at 12 19 31 PM

WP 6.3

Screenshot 2024-04-05 at 12 19 51 PM

Testing Instructions

  • Install WP 6.5
  • Use this branch / zip to check the form builder sidebar tabs
  • Check on a couple previous WP versions as well.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to master April 5, 2024 16:24
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🌈

@jonwaldstein jonwaldstein merged commit b550b45 into master Apr 5, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/wp65-sidebar-tabs branch April 5, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants