Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Resolve incompatibility issue with WP 6.5 #7342

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Apr 4, 2024

Resolves GIVE-583

Description

This pull request introduces a hotfix for an incompatibility issue between Visual Form Builder and WordPress 6.5. Previously, any modification to a block resulted in a re-render. Upon investigation, I discovered this was caused by a function designed to ensure all blocks reside within a section block. However, this function was triggering a change to the form state on every modification. This pull request now verifies whether a change causes a block to be placed outside of a section block; if not, it simply ignores the remainder of the function.

Affects

Visual Form Builder

Visuals

CleanShot 2024-04-04 at 15 14 45

Testing Instructions

  1. Create/Open a form in the VFB
  2. Edit any block attribute
  3. Confirm the block remains selected
  4. Move a block to be placed outside of a section block
  5. Confirm a section block is automatically created and the moved block is placed within that new section

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski changed the base branch from develop to master April 4, 2024 18:22
@pauloiankoski pauloiankoski changed the title Fix: Resolve incompatibility issue with WP 6.5 Hotfix: Resolve incompatibility issue with WP 6.5 Apr 4, 2024
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sleuthing @pauloiankoski 🧙!

@jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein merged commit 65157f8 into master Apr 4, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the hotfix/wp-65-compatibility branch April 4, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants