Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add convertkit add-on to the form migration process #7333

Merged
merged 23 commits into from
May 7, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Mar 26, 2024

Resolves # GIVE-455

Description

This PR adds a step in the form migration process to convert ConvertKit data from v2 forms to v3 forms and includes the methods required to facilitate this in the FormMetaDecorator.

It also includes unit tests on the form migration process for the Convertkit add-on. Three tests were added that check when migrating a form that uses the global settings, migrating a form that has per-form settings & migrating a form without meta.

Additional context

While Migrating the form if enabled globally from the global settings is selected the form migration should assume that it should migrate the form with the add-on block. On the v2 form if "use default" is selected the form should migrate with global settings. If "customize" is selected it should migrate via the form settings. If "disabled" is selected while enabled globally is selected it should not migrate the form with the add-on block.

Affects

Form Migration

Visuals

convertkit-global-settings.mov
convertkit-form-settings.mov

Testing Instructions

  • Set your global settings
  • add a v2 form -> then migrate the form without editing the form settings.
  • Verify the v3 form has the correct settings set from the global options.
  • Create another v2 form -> update the per-form settings on the right -> then migrate the form
  • Verify the v3 form has the correct settings set from the form options.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review March 26, 2024 23:19
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: add ConvertKit form migration Feature: add convertkit add-on to the form migration process Apr 24, 2024
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@jonwaldstein jonwaldstein merged commit 2d0b076 into develop May 7, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/convertkit-form-migration-GIVE-455 branch May 7, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants