-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add convertkit add-on to the form migration process #7333
Merged
jonwaldstein
merged 23 commits into
develop
from
feature/convertkit-form-migration-GIVE-455
May 7, 2024
Merged
Feature: add convertkit add-on to the form migration process #7333
jonwaldstein
merged 23 commits into
develop
from
feature/convertkit-form-migration-GIVE-455
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck for empty string values
This reverts commit 3a0eadb.
JoshuaHungDinh
changed the title
Feature: add ConvertKit form migration
Feature: add convertkit add-on to the form migration process
Apr 24, 2024
pauloiankoski
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # GIVE-455
Description
This PR adds a step in the form migration process to convert ConvertKit data from v2 forms to v3 forms and includes the methods required to facilitate this in the FormMetaDecorator.
It also includes unit tests on the form migration process for the Convertkit add-on. Three tests were added that check when migrating a form that uses the global settings, migrating a form that has per-form settings & migrating a form without meta.
Additional context
While Migrating the form if enabled globally from the global settings is selected the form migration should assume that it should migrate the form with the add-on block. On the v2 form if "use default" is selected the form should migrate with global settings. If "customize" is selected it should migrate via the form settings. If "disabled" is selected while enabled globally is selected it should not migrate the form with the add-on block.
Affects
Form Migration
Visuals
convertkit-global-settings.mov
convertkit-form-settings.mov
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks