Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Double The Donation migration step #7326

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented Mar 25, 2024

Resolves: GIVE-497

Description

This PR adds the Double The Donation migration step.

Affects

Form migration

Testing Instructions

Create a V2 form with Company Matching enabled
Upgrade form to V3
DTD block should be added to V3 from

Now repeat the process with the Company Matching disabled
DTD block should not be added to V3 from

Pre-review Checklist

  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

@alaca alaca requested a review from jonwaldstein March 25, 2024 08:28
@jonwaldstein jonwaldstein self-requested a review March 25, 2024 20:51
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alaca great job!

@jonwaldstein
Copy link
Contributor

@alaca adding reminder for both of us - when adding a form migration step we also want to uncomment from the supported addon list:

'Double the Donation' => defined('GIVE_DTD_NAME')

@jonwaldstein jonwaldstein merged commit ba764e7 into develop Apr 16, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/add-dtd-form-migration-GIVE-497 branch April 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants