Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: form builder page slug setting #6942

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix: form builder page slug setting #6942

merged 1 commit into from
Sep 14, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Sep 14, 2023

Description

This fixes the page slug setting in the form builder to properly clean the permalink before updating the value.

Affects

The page slug settings in the form builder

Visuals

N/A

Testing Instructions

  • Create a new or open an existing form
  • Go to the page slug setting and type in something with spaces like My Awesome Donation Form!
  • Save the form and make sure the slug is properly adjusted like my-awesome-donation-form

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review September 14, 2023 16:32
@jonwaldstein
Copy link
Contributor Author

@kjohnson this is ready for review.

Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I misunderstood at first and kept trying to change the form title... I can confirm that updating the slug manually does clean the value correctly for a URL.

@kjohnson kjohnson merged commit 94ae8bb into develop Sep 14, 2023
20 checks passed
@kjohnson kjohnson deleted the fix/form-page-slug branch September 14, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants