Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set read more link and wrap text in a p tag on Feature Notice modal #6940

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Sep 13, 2023

Description

This PR replaces the "read more" link with the actual value. Additionally, it wraps the text in a paragraph tag to allow for the application of margins. Previously, the text would collapse into the button when there were no addons or gateways to list.

Visuals

CleanShot 2023-09-13 at 17 57 27
CleanShot 2023-09-13 at 17 56 56

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pauloiankoski pauloiankoski merged commit 416fe7b into develop Sep 14, 2023
20 checks passed
@pauloiankoski pauloiankoski deleted the fix/feature-notice-link branch September 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants