Fix: Escape double quotes in emailTemplateOptions #6938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
commented
Sep 13, 2023
| $self = new self(); | ||
| $array = json_decode($json, true); | ||
|
|
||
| return $self::fromArray($array); |
There was a problem hiding this comment.
FormSettings::fromArray() is a static method and creates its own instance of the FormSettings object.
kjohnson
changed the title
|
@kjohnson im getting this now: 
|
|
@jonwaldstein I updated the escaping to be recursive. |
jonwaldstein
approved these changes
Sep 14, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR escapes the nested array properties for
FormSettings::$emailTemplateOptionswhen converting the form settings to JSON.Testing Instructions