Add currency switcher support to paypal donation payment gateway #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
changed the base branch from
develop
to
epic/paypal-commerce-integration-4886
JasonTheAdams
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Great work, @ravinderk! This works very well with Currency Switcher and cleans up the SDK switching code, too. 🚀
JasonTheAdams
deleted the
feature/add-support-for-currency-switcher-5342
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5324
Description
This pr adds a feature to process multiple currencies with donation form without reloading webpage.
Note: I am still facing issues when passing
inte=subscriptionin param SDK URL: paypal/paypal-sdk-client#46 (comment). Currently onetime and subscription payment processing without any issue withintent=captureAffects
Javascript which renders PayPal payments refactored completed to the setup payment method on basis of donor choices.
Pre-review Checklist
@sincetags included in DocBlocksTesting Instructions
npm i && npm run dev && composer dumpfor this pr