Merge branch 'develop' into release/3.14.0

impress-org · Jul 17, 2024 · 031fb45 · 031fb45
2 parents 2f0b601 + 0c9bc54
commit 031fb45
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/DonationForms/V2/Endpoints/Endpoint.php b/src/DonationForms/V2/Endpoints/Endpoint.php
@@ -26,6 +26,16 @@ public function validateInt($value)
         return filter_var($value, FILTER_VALIDATE_INT);
     }
 
+    /**
+     * @unreleased
+     * @param  string  $id
+     * @return bool
+     */
+    public function validatePostType(string $id)
+    {
+        return get_post_type($id) === 'give_forms';
+    }
+
     /**
      * Check user permissions
      * @return bool|WP_Error

diff --git a/src/DonationForms/V2/Endpoints/FormActions.php b/src/DonationForms/V2/Endpoints/FormActions.php
@@ -7,6 +7,7 @@
 use WP_REST_Response;
 
 /**
+ * @unreleased updated to validate form id is a donation form post type
  * @since 2.19.0
  */
 class FormActions extends Endpoint
@@ -47,7 +48,7 @@ public function registerRoute()
                         'required'          => true,
                         'validate_callback' => function ($ids) {
                             foreach ($this->splitString($ids) as $id) {
-                                if ( ! $this->validateInt($id)) {
+                                if ( ! $this->validateInt($id) || !$this->validatePostType($id)) {
                                     return false;
                                 }
                             }