update eslint-import-resolver-webpack homepage to the source of the p… #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jan 8, 2018
| @@ -27,7 +27,7 @@ | |||
| "bugs": { | |||
| "url": "https://github.com/benmosher/eslint-plugin-import/issues" | |||
| }, | |||
| "homepage": "https://github.com/benmosher/eslint-plugin-import#readme", | |||
| "homepage": "https://github.com/benmosher/eslint-plugin-import/tree/master/resolvers/webpack", | |||
There was a problem hiding this comment.
hardcoding "master" here is dangerous; I think maybe https://github.com/benmosher/eslint-plugin-import#resolvers is a better place to link to
There was a problem hiding this comment.
I was just following the pattern in the babel lerna repo. I very much doubt git's going to change the default branch from master any time soon.
There was a problem hiding this comment.
github wouldn't, but any maintainer might - that's not the danger i'm concerned with. I don't want to link to a directory that might disappear in a future refactoring.
There was a problem hiding this comment.
I get what you're saying @ljharb, but this looks reasonable enough, especially if this is a well-known lerna pattern.
ljharb
reviewed
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ackage