Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register TypeScript nodes as exports #929

Merged
merged 4 commits into from
Jan 4, 2018
Merged

Register TypeScript nodes as exports #929

merged 4 commits into from
Jan 4, 2018

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Sep 15, 2017

This ensures that code using export enum Foo {} or export abstract class Bar {} registers those as exports that can be imported in other files.

ljharb
ljharb approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests that will prevent a regression (assuming we have TypeScript tests already)?

@j-f1
Copy link
Contributor Author

j-f1 commented Sep 19, 2017

Sure, I’ll do that tomorrow. Hopefully.

@j-f1
Copy link
Contributor Author

j-f1 commented Sep 28, 2017 •
edited
Loading

The parsing error is fixed in #925. Sorry for the delay in working on this!

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 8435935 on j-f1:patch-2 into 9f42bed on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 8435935 on j-f1:patch-2 into 9f42bed on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 8435935 on j-f1:patch-2 into 9f42bed on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 8435935 on j-f1:patch-2 into 9f42bed on benmosher:master.

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 3207306 on j-f1:patch-2 into 9f42bed on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 3207306 on j-f1:patch-2 into 9f42bed on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 3207306 on j-f1:patch-2 into 9f42bed on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.103% when pulling 3207306 on j-f1:patch-2 into 9f42bed on benmosher:master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 96.172% when pulling 7ae0233 on j-f1:patch-2 into 34e4b95 on benmosher:master.

@ljharb ljharb merged commit 1c41350 into import-js:master Jan 4, 2018
@ljharb ljharb mentioned this pull request Jan 4, 2018
Closed
@j-f1 j-f1 deleted the patch-2 branch January 4, 2018 13:00
@renovate renovate bot mentioned this pull request Feb 22, 2018
Merged
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
typescript
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-f1 @coveralls @ljharb