Flow types support in the order rule

[avaly]

Closes #645

PS: I also included a yarn.lock file: https://yarnpkg.com/en/docs/version-control

Please autosquash my fixup commits before merging. 😄

[coveralls]

Coverage increased (+0.009%) to 94.921% when pulling 0cf4653 on avaly:order-flow-types into 790dd66 on benmosher:master.

[ljharb]

Adding yarn.lock should be a separate change (one I disagree with, not the least of which is because this isn't a top-level app). Would you mind separating it into a separate PR?

[avaly]

I removed the yarn.lock file.

[coveralls]

Coverage increased (+0.009%) to 94.921% when pulling bd16b98 on avaly:order-flow-types into 790dd66 on benmosher:master.

[coveralls]

Coverage increased (+0.009%) to 94.921% when pulling bd16b98 on avaly:order-flow-types into 790dd66 on benmosher:master.

[coveralls]

Coverage decreased (-1.3%) to 93.623% when pulling ecc0fcb on avaly:order-flow-types into 790dd66 on benmosher:master.

[coveralls]

Coverage increased (+0.009%) to 94.921% when pulling ecc0fcb on avaly:order-flow-types into 790dd66 on benmosher:master.

[jfmengels]

Thanks a lot for your work on this @avaly!

Since the issue was created, Flow v0.38 came out and allowed importing both types and values in a single import statement, which sounds like a way better syntax to me and would make this new type less useful.

I described my concerns and propositions on the original issue, let me know what you think #645 (comment)

[avaly]

@jfmengels I was aware of the new syntax in Flow 0.38, however I still feel this PR is relevant. Since the old syntax to import Flow types is still available, this rule should at least offer the opportunity to configure the code style some may want for their projects. Personally, I still prefer having all the Flow types imports separate from the normal imports.

[avaly]

Any more thoughts on this? I would really like to have this available.

[jfmengels]

The order rule is about the imported module, not what is being imported. I'm pretty sure that if we add the type/flow import type, then we'd soon have a request to order the type imports with the same logic (so you'd need subtypes like flow parent, flow external, ...), which would make sense because that is the purpose of this rule to start with, and things will start to get messy.
Having this new feature in Flow 0.38 is a fortunate and welcome solution to this problem IMO.

I don't want to tell you and other users how to import your types, but I really don't think this is the best way to handle this... I'm open to comments though.

Please note that if you really feel like going this path anyway, you always have the option to fork this plugin and create a new package with the forked order rule.

(cc @gajus who opened the original issue, if you feel like commenting)

[avaly]

I'll close this PR and fork this rule into a separate package.

[coveralls]

Coverage decreased (-2.6%) to 92.364% when pulling 2742ca5 on avaly:order-flow-types into 98e7048 on benmosher:master.