Support webpack 2.2-rc #695
Conversation
|
@benmosher I can't work out why appveyor is failing |
|
The appveyor error is not related. The same error happens on other PRs too. I think that it's an error on their side. I'm fine with this change, but would it not be possible to instead say that we support webpack 2.x.x (rc or not)? Since it's a release candidate, it's very unlikely to have breaking changes that will affect this plugin. Just to avoid having to re-do a similar PR when the final v2 release is made. |
|
This seems to be what the official (under the webpack project on github) loaders and plugins do |
|
@jfmengels @benmosher any update on merging this? |
|
Is there anything additional required here? I would love to see this get merged as it's blocking the upgrade to Webpack 2. Happy to help if there's anything else needed. |
|
@benmosher this seems to be blocking a fair few projects... |
|
Will this be merged? It's been almost 3 weeks since it was originally submitted (admittedly including the holidays), but I would really love to keep using this plugin if at all possible. |
|
@benmosher now that extract-text-webpack-plugin is out. This is the last project blocking me from enjoying the glory of webpack 2rc. |
2 similar comments
|
published as v0.8.1 of the webpack resolver 😎 |
|
btw, thanks for reviewing @jfmengels! |
No problem. I'll try to do some more, I've been neglecting too many projects lately... @graingert Do we need to make a similar change for webpack 2.2.0-alpha and webpack 2.2.0? |
|
should just work for 2x |
|
Sorry. Did you mean that we should make a change to support webpack 2-x-x, or that this is already good? The former, right? |
|
@jfmengels |
No description provided.