-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.1.0 #647
Merged
Merged
Release 2.1.0 #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # resolvers/webpack/.babelrc
…ive filename. Fixes #602.
* Add empty `no-named-default` rule and tests (failing) * Functioning `no-named-default` rule with tests * Document `no-named-default` rule * Add `no-named-default` to README * Simplify docs * Add `no-named-default` note to CHANGELOG * Remove unnecessary check for `name` key * Simplify rule logic, add new test, fix syntax error in docs * Remove source check, use template literal syntax for message * Simplify rationale in docs
This reverts commit 2cbd801.
jfmengels
approved these changes
Nov 2, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no blocking PRs, but I think we could include #639, which looks fine to me.
LGTM otherwise :)
@jfmengels ah yeah, #639 looks good. will do, thanks! |
* Ignoring flow type exports, resolve #484 * Added test and note to CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also need to:
RELEASE.md
master
,release-2.1.0
npm publish
(cd resolvers/webpack && npm publish)
v2.1.0
+resolvers/webpack/v0.7.0
)release
intomaster