Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v1.14.0 #504

Merged
merged 21 commits into from
Aug 22, 2016
Merged

release v1.14.0 #504

merged 21 commits into from
Aug 22, 2016

Conversation

benmosher
Copy link
Member

cc @jfmengels. I want to get import/parsers published so I can use it at work.

Also I clearly forgot to do this for 1.13.0 😳, only changes are the bugfix for #416 (PR #499) and import/parsers via #503. I have QA'd.

PR summary:

It'd probably be good if you took a look at the import/parsers config schema. Though v2 is on the horizon so we could break it if needed/desired as part of that release... only thing I'm thinking is whether it should be glob- or regex-based instead of array-of-extensions. I like AoE mostly for consistency with import/extensions, and it's easy to grok. Con: less powerful, but could be enhanced to support glob/regex later if desired.

@coveralls
Copy link

coveralls commented Aug 20, 2016

Coverage Status

Coverage increased (+0.08%) to 97.722% when pulling 8a68fbb on master into 4429edf on release.

@jfmengels
Copy link
Collaborator

whether it should be glob- or regex-based instead of array-of-extensions

You should probably create an issue to discuss this, so that people interested by this participate and give their meaning.
I like the glob idea, as long as you allow an array of globs (["src/**/*.ts", "!src/foo/**/*.ts"]), as it gives you more control over how to control this setting. But before doing that, I would like to know of at least one use case that would benefit from a regex/glob configuration, because I can't seem to think of one.

I've left you a comment here https://github.com/benmosher/eslint-plugin-import/pull/503/files#r75605034, but LGTM otherwise.

@coveralls
Copy link

coveralls commented Aug 21, 2016

Coverage Status

Coverage increased (+0.08%) to 97.722% when pulling c806630 on master into 4429edf on release.

@benmosher
Copy link
Member Author

But before doing that, I would like to know of at least one use case that would benefit from a regex/glob configuration, because I can't seem to think of one.

Yeah, this is where I ended up as well, thinking through it. Globs are great, and very expressive, but I feel like >95% of the time, one or two file extensions will be totally sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants