Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] add TypeScript types #3097

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[New] add TypeScript types #3097

merged 1 commit into from
Dec 11, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 8, 2024

For now I've just typed these out manually based on what we're using internally - while it would be good to have some tests at some point, I'm hoping/recommending not blocking on that for now as I think the types are small enough to be easy to maintain manually for the time being.

Resolves #3090

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (d5f2950) to head (192b5fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3097   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files          83       83           
  Lines        3583     3583           
  Branches     1252     1251    -1     
=======================================
  Hits         3394     3394           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Nov 8, 2024

Can we add a tsc run, at least?

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
@G-Rath G-Rath force-pushed the add-types branch 2 times, most recently from 1713c9d to 58d17dc Compare November 8, 2024 17:25
@G-Rath
Copy link
Contributor Author

G-Rath commented Nov 8, 2024

Can we add a tsc run, at least?

Done - note that it requires using typescript v5 since types like @types/node require that version, which led to a weird "works locally but not in CI", but I think I've got that resolved and should be good enough for now 🤞

.github/workflows/node-4+.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link

socket-security bot commented Nov 10, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this without verifications in place, but it'll be very very important to add that soon.

@ljharb ljharb merged commit 9d1f639 into import-js:main Dec 11, 2024
342 checks passed
@G-Rath G-Rath deleted the add-types branch December 11, 2024 19:44
@michaelfaith
Copy link
Contributor

Nice work on this!

@anmiles
Copy link

anmiles commented Jan 12, 2025

@ljharb would you mind to get this published on npmjs.com, please? The latest version 2.31.0 still doesn't have this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Could not find a declaration file for module 'eslint-plugin-import'
5 participants