Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] no-unused-modules: Add ignoreUnusedTypeExports option #3011

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[New] no-unused-modules: Add ignoreUnusedTypeExports option #3011

merged 1 commit into from
Jul 19, 2024

Conversation

silverwind
Copy link
Contributor

Fixes: #2694

@silverwind
Copy link
Contributor Author

Will tweak tests a bit.

@silverwind
Copy link
Contributor Author

Ok, tests are fine now.

@silverwind silverwind mentioned this pull request May 28, 2024
Closed
@ljharb
Copy link
Member

ljharb commented May 28, 2024

This seems great, except that it's best when boolean arguments default to false. Can you come up with an alternative name for it so it can default to false?

@silverwind
Copy link
Contributor Author

This seems great, except that it's best when boolean arguments default to false. Can you come up with an alternative name for it so it can default to false?

Hmm I could invert the name and function but thought that the current name matches nicely into the existing options missingExports and unusedExports.

@silverwind silverwind changed the title [New] no-unused-modules: Add unusedTypeExports option [New] no-unused-modules: Add ignoreUnusedTypeExports option May 28, 2024
@silverwind
Copy link
Contributor Author

Inverted it, so now it's ignoreUnusedTypeExports defaulting to false.

@ljharb
Copy link
Member

ljharb commented May 28, 2024

Your original option name definitely did match better, but i prioritize booleans defaulting to false over option names :-) thanks!

@silverwind silverwind mentioned this pull request May 28, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (fc361a9) to head (e96db1a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3011   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          78       78           
  Lines        3296     3299    +3     
  Branches     1158     1160    +2     
=======================================
+ Hits         3165     3168    +3     
  Misses        131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silverwind
Copy link
Contributor Author

This CI failures seem intermittent and the coverage annotation "Added line #L518 was not covered by tests" is incorrect, I verified the line is being hit during tests.

@SukkaW SukkaW mentioned this pull request Jul 8, 2024
Open
@silverwind silverwind mentioned this pull request Jul 18, 2024
Merged
@ljharb
Copy link
Member

ljharb commented Jul 18, 2024

node 22.5 itself is broken rn, so i'll rerun those failing jobs once a fixed 22.5.1 is released.

@ljharb ljharb merged commit 09476d7 into import-js:main Jul 19, 2024
308 of 310 checks passed
@silverwind silverwind deleted the unusedTypeExports branch July 22, 2024 15:23
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 4, 2024
@renovate
Update dependency eslint-plugin-import to v2.30.0
0894b88 
| datasource | package              | from   | to     |
| ---------- | -------------------- | ------ | ------ |
| npm        | eslint-plugin-import | 2.29.1 | 2.30.0 |


## [v2.30.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2300---2024-09-02)

##### Added

-   \[`dynamic-import-chunkname`]: add `allowEmpty` option to allow empty leading comments (\[[#2942](import-js/eslint-plugin-import#2942)], thanks \[[@JiangWeixian](https://github.com/JiangWeixian)])
-   \[`dynamic-import-chunkname`]: Allow empty chunk name when webpackMode: 'eager' is set; add suggestions to remove name in eager mode (\[[#3004](import-js/eslint-plugin-import#3004)], thanks \[[@amsardesai](https://github.com/amsardesai)])
-   \[`no-unused-modules`]: Add `ignoreUnusedTypeExports` option (\[[#3011](import-js/eslint-plugin-import#3011)], thanks \[[@silverwind](https://github.com/silverwind)])
-   add support for Flat Config (\[[#3018](import-js/eslint-plugin-import#3018)], thanks \[[@michaelfaith](https://github.com/michaelfaith)])

##### Fixed

-   \[`no-extraneous-dependencies`]: allow wrong path (\[[#3012](import-js/eslint-plugin-import#3012)], thanks \[[@chabb](https://github.com/chabb)])
-   \[`no-cycle`]: use scc algorithm to optimize (\[[#2998](import-js/eslint-plugin-import#2998)], thanks \[[@soryy708](https://github.com/soryy708)])
-   \[`no-duplicates`]: Removing duplicates breaks in TypeScript (\[[#3033](import-js/eslint-plugin-import#3033)], thanks \[[@yesl-kim](https://github.com/yesl-kim)])
-   \[`newline-after-import`]: fix considerComments option when require (\[[#2952](import-js/eslint-plugin-import#2952)], thanks \[[@developer-bandi](https://github.com/developer-bandi)])
-   \[`order`]: do not compare first path segment for relative paths (\[[#2682](import-js/eslint-plugin-import#2682)]) (\[[#2885](import-js/eslint-plugin-import#2885)], thanks \[[@mihkeleidast](https://github.com/mihkeleidast)])

##### Changed

-   \[Docs] `no-extraneous-dependencies`: Make glob pattern description more explicit (\[[#2944](import-js/eslint-plugin-import#2944)], thanks \[[@mulztob](https://github.com/mulztob)])
-   \[`no-unused-modules`]: add console message to help debug \[[#2866](import-js/eslint-plugin-import#2866)]
-   \[Refactor] `ExportMap`: make procedures static instead of monkeypatching exportmap (\[[#2982](import-js/eslint-plugin-import#2982)], thanks \[[@soryy708](https://github.com/soryy708)])
-   \[Refactor] `ExportMap`: separate ExportMap instance from its builder logic (\[[#2985](import-js/eslint-plugin-import#2985)], thanks \[[@soryy708](https://github.com/soryy708)])
-   \[Docs] `order`: Add a quick note on how unbound imports and --fix (\[[#2640](import-js/eslint-plugin-import#2640)], thanks \[[@MinervaBot](https://github.com/minervabot)])
-   \[Tests] appveyor -> GHA (run tests on Windows in both pwsh and WSL + Ubuntu) (\[[#2987](import-js/eslint-plugin-import#2987)], thanks \[[@joeyguerra](https://github.com/joeyguerra)])
-   \[actions] migrate OSX tests to GHA (\[[ljharb#37](ljharb/eslint-plugin-import#37)], thanks \[[@aks-](https://github.com/aks-)])
-   \[Refactor] `exportMapBuilder`: avoid hoisting (\[[#2989](import-js/eslint-plugin-import#2989)], thanks \[[@soryy708](https://github.com/soryy708)])
-   \[Refactor] `ExportMap`: extract "builder" logic to separate files (\[[#2991](import-js/eslint-plugin-import#2991)], thanks \[[@soryy708](https://github.com/soryy708)])
-   \[Docs] \[`order`]: update the description of the `pathGroupsExcludedImportTypes` option (\[[#3036](import-js/eslint-plugin-import#3036)], thanks \[[@liby](https://github.com/liby)])
-   \[readme] Clarify how to install the plugin (\[[#2993](import-js/eslint-plugin-import#2993)], thanks \[[@jwbth](https://github.com/jwbth)])
@Mastermindzh Mastermindzh mentioned this pull request Sep 24, 2024
Closed
@lholmquist lholmquist mentioned this pull request Sep 24, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Sep 24, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 24, 2024
Closed
@alhugot-azpn alhugot-azpn mentioned this pull request Sep 24, 2024
Merged
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 24, 2024
Open
@Loonz206 Loonz206 mentioned this pull request Sep 24, 2024
Merged
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 24, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Sep 25, 2024
Open
@NOUIY NOUIY mentioned this pull request Sep 25, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Sep 25, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Sep 25, 2024
Open
This was referenced Sep 26, 2024
Open
Open
@qdraw qdraw mentioned this pull request Sep 28, 2024
Closed
@DadonStyle DadonStyle mentioned this pull request Sep 28, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Oct 3, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 3, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 4, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 5, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[import/no-unused-modules] Add an option to ignore typescript types
2 participants
@silverwind @ljharb