Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Correcting peerDependencies option default to true #1993

Merged
merged 1 commit into from
May 12, 2021
Merged

[Docs] Correcting peerDependencies option default to true #1993

merged 1 commit into from
May 12, 2021

Conversation

dwardu
Copy link
Contributor

@dwardu dwardu commented Feb 24, 2021

Kindly confirm that the default really is true.

@dwardu dwardu changed the title Correcting peerDependencies option to true Correcting peerDependencies option default to true Feb 24, 2021
@coveralls
Copy link

coveralls commented Feb 24, 2021 •
edited
Loading

Coverage Status

Coverage increased (+14.5%) to 83.969% when pulling cd48ef6 on dwardu:patch-1 into b44d9c2 on benmosher:master.

ljharb
ljharb approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this seems to have been set in #428 but the docs not updated.

@ljharb ljharb added the docs label Feb 24, 2021
@ljharb
Copy link
Member

ljharb commented Feb 24, 2021

(linking to #428)

@ljharb ljharb changed the title Correcting peerDependencies option default to true [Docs] Correcting peerDependencies option default to true May 12, 2021
@ljharb ljharb merged commit cd48ef6 into import-js:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwardu @coveralls @ljharb