-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: add custom groups #1799
base: main
Are you sure you want to change the base?
[WIP]: add custom groups #1799
Conversation
guys) would be really nice to have such feature |
2 similar comments
@ljharb that's my first PR into this repo what do you think if such api? i'm trying to understand if such solution is okay and continue development if so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping :-) I think this is a reasonable direction; i'd hope for a few more test cases, and especially some that test that gitignored/eslintignored files are not included even if a glob covers them.
for (let globPatter of groups) { | ||
if (minimatch(name, globPatter)) { | ||
return globPatter | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (let globPatter of groups) { | |
if (minimatch(name, globPatter)) { | |
return globPatter | |
} | |
} | |
return groups.find(globPattern => minimatch(name, globPattern) |
Hey, is this being worked on? I could really use this feature. I could even help with it - just let me know what else needs to be done. |
@tomasloksa if you'd like to help, please feel free to comment with a link to your own branch, and i'll pull the commits into this PR :-) |
[DARFT]
Based on issue: #1015
Adds a possibility to pass custom glob pattern as a custom group
Usage example