Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint comma-dangle violations #1520

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix eslint comma-dangle violations #1520

merged 1 commit into from
Dec 5, 2019

Conversation

brendo
Copy link
Contributor

@brendo brendo commented Oct 28, 2019 •
edited
Loading

It appears recent changes to comma-dangle (eslint/eslint#12462) with ESLint v6 have started to make recent PR's in this repo fail:

This PR runs eslint --fix . to resolve the errors.

@coveralls
Copy link

coveralls commented Oct 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.034% when pulling 1b96580 on brendo:chore_fix-eslint into a0614a7 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.202% when pulling e00c859 on brendo:chore_fix-eslint into 112a0bf on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.202% when pulling e00c859 on brendo:chore_fix-eslint into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.202% when pulling e00c859 on brendo:chore_fix-eslint into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.202% when pulling e00c859 on brendo:chore_fix-eslint into 112a0bf on benmosher:master.

@joaovieira joaovieira mentioned this pull request Oct 30, 2019
Closed
@ljharb ljharb merged commit 1b96580 into import-js:master Dec 5, 2019
@brendo brendo deleted the chore_fix-eslint branch December 5, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendo @coveralls @ljharb