Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-commonjs: add tests that show corner cases #1308

Merged
merged 1 commit into from
Mar 27, 2019
Merged

no-commonjs: add tests that show corner cases #1308

merged 1 commit into from
Mar 27, 2019

Conversation

andrewtamura
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.2%) to 97.336% when pulling be4f1c7 on TakeScoop:root-require into 206d676 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+3.2%) to 97.336% when pulling be4f1c7 on TakeScoop:root-require into 206d676 on benmosher:master.

@ljharb ljharb changed the title Add rules that show corner cases for commonJS no-commonjs: add tests that show corner cases Mar 27, 2019
ljharb
ljharb approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit af976b9 into import-js:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewtamura @coveralls @ljharb