Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.11.0 #1071

Merged
merged 20 commits into from
Apr 12, 2018
Merged

Release 2.11.0 #1071

merged 20 commits into from
Apr 12, 2018

Conversation

benmosher
Copy link
Member

  • publish to npm

futpib and others added 17 commits June 23, 2017 18:26
@futpib @ljharb
Add allow-require option to no-commonjs rule
ec03d0c 
This fixes #548
@futpib @ljharb
Switch no-commonjs to object options
d038a0c
@futpib @ljharb
Add note on dynamic require vs dynamic import
1c9f61c
@futpib @ljharb
Add options schema to no-commonjs rule
c438d3e
@oliviertassinari @benmosher
Webpack -> webpack
6fe78a9 
Use the official project name: https://github.com/webpack/webpack.
@fnknzzz @benmosher
add fixer for first (#1046)
a2acbde
@benmosher
changelog note for #1046
48d0a8a
@ljharb
Merge pull request #880 from futpib/no-commonjs-allow-require
ee15fa4 
Add `allow-require` option to `no-commonjs` rule
@ljharb
[Fix] no-cycle: create must *always* return an object, even if th…
19fc3df 
…ere’s no listeners
@sharmilajesupaul
minor typo in import/no-cycle rule docs
f13f18e
@ljharb
Merge pull request #1065 from sharmilajesupaul/minor-typo-fix
80d1ceb 
minor typo in import/no-cycle rule docs
@ljharb
Merge pull request #1064 from ljharb/fix_no_cycle
d8077c8 
[Fix] `no-cycle`: `create` must *always* return an object, even if no listeners
@ljharb
[patch] use resolve instead of builtin-modules
fb8e1e5
@ljharb
Merge pull request #1069 from ljharb/resolve
f0b4f3e 
[patch] use `resolve` instead of `builtin-modules`
@benmosher
bump to v2.10.1
0ff8f23
@benmosher
changelog for #880
54e3013
@benmosher
bump to v2.11.0 for #880 (semver-minor)
83c85fc
@benmosher benmosher changed the title Release 2.10.1 Release 2.11.0 Apr 9, 2018
@benmosher
Copy link
Member Author

ignore the branch name. I forgot #880 was merged.

@benmosher
Copy link
Member Author

I'm thinking I'll wait to publish 2.11 until #1058 is fixed.

@coveralls
Copy link

coveralls commented Apr 9, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 96.47% when pulling 83c85fc on release-2.10.1 into f3ff68f on release.

ljharb
ljharb approved these changes Apr 9, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with or without the perf fix.

ljharb
ljharb approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we should update the release and publish it anyways; the perf regression can wait?

@benmosher
Copy link
Member Author

I fixed it, will publish now

@benmosher benmosher merged commit e0dcfbd into release Apr 12, 2018
@ljharb ljharb deleted the release-2.10.1 branch April 12, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@benmosher @coveralls @ljharb @futpib @oliviertassinari @fnknzzz @sharmilajesupaul