[WIP] Do not report type imports from flow-typed packages #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing types from packages that are defined in a file inside the `flow-typed` directory, prevent the `named` rule from reporting that the package itself does not provide an export with that name. Currently there is support for type imports from local files. Restrict these checks to imports with relative paths.
tf
force-pushed
the
ignore-type-import-from-package
branch
from
32b84cb to
16f678b
Compare
|
I think we’ve opened roughly the same pull request, you might be interested in the discussion here: #1057 |
|
Indeed; thanks for your contribution, but this is a duplicate of #1057. |
This was referenced Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #960
When importing types from packages that are defined in a file inside the
flow-typeddirectory, prevent thenamedrule from reporting that the package itself does not provide an export with that name.Currently there is support for type imports from local files. Restrict these checks to imports with relative paths.
I'm not really sure how much value checking type imports provides since, I suppose, Flow itself is already good at alerting about missing imported types. Maybe type imports should not be checked at
all? At least that appears to be the route already taken in
no-extraneous-dependencies. Does the same hold for Type Scripts?The alternative of making the
namedrule aware of the top levelflow-typeddirectory feels a lot like duplicating functionality that already exists inside Flow.