-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-mutable-exports fails when exporting types (flow) #758
Comments
Sure, that'd be great - a PR with a test case would be very helpful :-) |
This tests the bug reported in issue import-js#758, which was actually already fixed in PR import-js#660.
@ljharb, @benmosher -- I was running into this issue, and wrote a test case, and then was very confused when I couldn't get it to fail.... until I looked closer and realized that the bug had already been fixed in master! (See my PR #835 for a test, and #660 for the code that fixed the test.) Any chance you could push out a new bugfix version for this? Thanks!! |
If the fix was done in November, why was this issue posted in March? |
I believe the latest version published on NPM is from November 7 (2.2.0 at baa6b8a) and the commit that fixes this was made on November 14. My finding was based only on the published version. |
ah, gotcha. looks like we're overdue for a release :-) |
I was trying to do an export like the following:
Having that on the file would throw the following exception:
By just removing that rule I was able to make it keep working, I think it would be nice for this plugin to also support flow (or not crash because of it).
The text was updated successfully, but these errors were encountered: