(#610): Fix crash when calling require() with a number

import-js · Oct 6, 2016 · e282c42 · e282c42
1 parent 4f3aa28
commit e282c42
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/core/staticRequire.js b/src/core/staticRequire.js
@@ -5,5 +5,6 @@ export default function isStaticRequire(node) {
     node.callee.type === 'Identifier' &&
     node.callee.name === 'require' &&
     node.arguments.length === 1 &&
-    node.arguments[0].type === 'Literal'
+    node.arguments[0].type === 'Literal' &&
+    typeof node.arguments[0].value === 'string'
 }
diff --git a/tests/src/rules/no-extraneous-dependencies.js b/tests/src/rules/no-extraneous-dependencies.js
@@ -45,6 +45,7 @@ ruleTester.run('no-extraneous-dependencies', rule, {
       options: [{devDependencies: ['*.test.js', '*.spec.js']}],
       filename: 'foo.spec.js',
     }),
+    test({ code: 'require(6)' }),
   ],
   invalid: [
     test({