add test + fixes #370

src/rules/no-deprecated.js

@@ -50,11 +50,11 @@ module.exports = function (context) {
       }
 
       // unknown thing can't be deprecated
-      if (!imports.has(imported)) return
+      const exported = imports.get(imported)
+      if (exported == null) return
 
       // capture import of deep namespace
-      const { namespace } = imports.get(imported)
-      if (namespace) namespaces.set(local, namespace)
+      if (exported.namespace) namespaces.set(local, exported.namespace)
 
       const deprecation = getDeprecation(imports.get(imported))
       if (!deprecation) return

tests/files/issue-370-commonjs-namespace/bar.js

@@ -0,0 +1,2 @@
+// bar.js
+export { default as foo } from './foo'

tests/files/issue-370-commonjs-namespace/foo.js

@@ -0,0 +1,2 @@
+// foo.js
+module.exports = { foo: 'foo' }

tests/src/rules/no-deprecated.js

@@ -1,4 +1,4 @@
-import { test } from '../utils'
+import { test, SYNTAX_CASES } from '../utils'
 
 import { RuleTester } from 'eslint'
 
@@ -37,6 +37,9 @@ ruleTester.run('no-deprecated', rule, {
     test({
       code: "import { deepDep } from './deep-deprecated'; function x(deepDep) { console.log(deepDep.MY_TERRIBLE_ACTION) }",
     }),
+
+
+    ...SYNTAX_CASES,
   ],
   invalid: [
 

tests/src/utils.js

@@ -63,4 +63,9 @@ export const SYNTAX_CASES = [
     settings: { 'import/extensions': ['.js'] }, // breaking: remove for v2
   }),
 
+  // issue #370: deep commonjs import
+  test({
+    code: 'import { foo } from "./issue-370-commonjs-namespace/bar"',
+    settings: { 'import/ignore': ['foo'] },
+  }),
  ]