Merge pull request #1039 from preco21/namespace-crash-fix

#656: Fix crashes that caused when using object-rest properties in `namespace` rule
import-js · Mar 7, 2018 · 158f4e8 · 158f4e8
2 parents 196c238 + 1a084cc
commit 158f4e8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/rules/namespace.js b/src/rules/namespace.js
@@ -161,6 +161,9 @@ module.exports = {
           if (pattern.type !== 'ObjectPattern') return
 
           for (let property of pattern.properties) {
+            if (property.type === 'ExperimentalRestProperty') {
+              continue
+            }
 
             if (property.key.type !== 'Identifier') {
               context.report({

diff --git a/tests/src/rules/namespace.js b/tests/src/rules/namespace.js
@@ -92,6 +92,20 @@ const valid = [
     options: [{ allowComputed: true }],
   }),
 
+  // #656: should handle object-rest properties
+  test({
+    code: `import * as names from './named-exports'; const {a, b, ...rest} = names;`,
+    parserOptions: {
+      ecmaFeatures: {
+        experimentalObjectRestSpread: true,
+      },
+    },
+  }),
+  test({
+    code: `import * as names from './named-exports'; const {a, b, ...rest} = names;`,
+    parser: 'babel-eslint',
+  }),
+
   ...SYNTAX_CASES,
 ]