New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset.fromJs creates an empty Set if type is SET #311

Open

denniswieczorek wants to merge 1 commit into implydata:master from denniswieczorek:master

denniswieczorek commented Apr 2, 2024

Currently, creation of datums via .fromJs ignores the attribute type if the value is an empty array

const dataset = Dataset.fromJs({
  attributes: [ { name: 'x', type: 'SET }]
  data: [ { x: [] }, { x: ['foo'] } ]
})

// dataset.data[0] is a Dataset
// dataset.data[1] is a Set

This fix checks attribute type so that there aren't a mix of types on .data


          Dataset.fromJs creates an empty Set if type is SET

4e27621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet