Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrentLimitRequest | fix requestFinished fired multiple times on error #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexmorten
Copy link

In an error case, both the error and the end callbacks are called, leading to negative outstandingRequests, effectively increasing the concurrentLimit by 1 for each error.

For us this sometimes snowballs, because an increased effectiveconcurrentLimit leads to more timeout errors, increasing the effective concurrentLimit further 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants