Adding unknownClientsChallenge and blockNonEssentialBots #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel-Koev
force-pushed
the
waf_security_rule_ddos_rule_extending
branch
2 times, most recently
from
7068082
to
fa5ea53
Compare
katrinpolit
reviewed
Sep 18, 2024
| "unknown_clients_challenge": { | ||
| Description: "Defines a method used for challenging suspicious bots. Possible values: none, cookies, javascript, captcha", | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
add enum validation func
| }, | ||
| "block_non_essential_bots": { | ||
| Description: "If non-essential bots should be blocked or not. Possible values: true, false", | ||
| Type: schema.TypeString, |
There was a problem hiding this comment.
consider adding validation func/ possible values: true, false, ""
There was a problem hiding this comment.
add value checks in tests after resource was applied
There was a problem hiding this comment.
review with Technical writer
Pavel-Koev
force-pushed
the
waf_security_rule_ddos_rule_extending
branch
5 times, most recently
from
6b7ef6d
to
9f35c10
Compare
katrinpolit
approved these changes
Sep 25, 2024
Pavel-Koev
force-pushed
the
waf_security_rule_ddos_rule_extending
branch
2 times, most recently
from
b917cec
to
c4cc88a
Compare
…ecurity ddos rules
Pavel-Koev
force-pushed
the
waf_security_rule_ddos_rule_extending
branch
from
c4cc88a
to
e8c98a9
Compare
BrachaY
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unknownClientsChallenge and blockNonEssentialBots to the waf security ddos rules