Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for SIGNIFICANT_SCRIPT_DISCOVERY and SIGNIFICANT_DATA_TRANSFER_DISCOVERY #420

Merged
merged 1 commit into from
May 20, 2024

Conversation

kkwon2
Copy link
Contributor

@kkwon2 kkwon2 commented May 3, 2024

  • Updating the CSP datasets to include SIGNIFICANT_SCRIPT_DISCOVERY and SIGNIFICANT_DATA_TRANSFER_DISCOVERY. These are already available in UI but not in terraform.

  • Updating the HTML page with new CSP datasets and provider info

  • Updating tests

@kkwon2
Copy link
Contributor Author

kkwon2 commented May 3, 2024

Building on top of previous PR #334

Copy link
Collaborator

@BrachaY BrachaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests - client tests and acceptance tests

@BrachaY BrachaY merged commit 403b89c into imperva:master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants