Extend ssl settings with tls configurations #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel-Koev
changed the title
katrinpolit
approved these changes
Oct 19, 2023
Pavel-Koev
force-pushed
the
CWMS-2926_extend_ssl_settings_with_tls_configurations
branch
from
efd7495
to
8c24dff
Compare
Pavel-Koev
force-pushed
the
CWMS-2926_extend_ssl_settings_with_tls_configurations
branch
from
3182ddd
to
d8de416
Compare
Pavel-Koev
force-pushed
the
CWMS-2926_extend_ssl_settings_with_tls_configurations
branch
from
d8de416
to
b390a48
Compare
katrinpolit
approved these changes
Nov 29, 2023
| log.Printf("[INFO] HSTS request json looks like this %s\n", requestJSON) | ||
| log.Printf("[INFO] HSTS request URL looks like this %s\n", reqURL) | ||
| resp, err := c.DoJsonRequestWithHeaders(http.MethodPost, reqURL, requestJSON, UpdateSiteSSLSettings) | ||
| // Post request to Incapsula |
katrinpolit
requested changes
Nov 29, 2023
Pavel-Koev
force-pushed
the
CWMS-2926_extend_ssl_settings_with_tls_configurations
branch
from
b390a48
to
04b5e4b
Compare
katrinpolit
approved these changes
Nov 29, 2023
Pavel-Koev
added a commit
to Pavel-Koev/terraform-provider-incapsula
that referenced
this pull request
Jan 25, 2024
…mperva#360)" This reverts commit f8af4b8.
BrachaY
pushed a commit
that referenced
this pull request
Jan 25, 2024
Pavel-Koev
added a commit
to Pavel-Koev/terraform-provider-incapsula
that referenced
this pull request
Mar 21, 2024
…ttings (imperva#360)" (imperva#386)" This reverts commit 64f99d8.
Pavel-Koev
added a commit
to Pavel-Koev/terraform-provider-incapsula
that referenced
this pull request
Mar 26, 2024
…ttings (imperva#360)" (imperva#386)" This reverts commit 64f99d8.
BrachaY
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the site ssl settings resource and adding inbound TLS settings that will allow clients to configure which tls versions and which ciphers to use at the site level.
And extending the already existing ssl settings resource tests to cover inbound TLS settings.