Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource site: add cname to domain validation + fix default values fr… #186

Merged
merged 1 commit into from
Jul 5, 2022
Merged

resource site: add cname to domain validation + fix default values fr… #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions incapsula/resource_site.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func resourceSite() *schema.Resource {
Computed: true,
},
"domain_validation": {
Description: "email or html or dns.",
Description: "email or html or dns or cname.",
Type: schema.TypeString,
Optional: true,
},
Expand Down Expand Up @@ -300,13 +300,13 @@ func resourceSite() *schema.Resource {
Description: "Use 'true' to add the naked domain SAN to a www site’s SSL certificate. Default value: true",
Type: schema.TypeBool,
Optional: true,
Default: "true",
Default: true,
},
"wildcard_san": {
Description: "Use 'true' to add the wildcard SAN or 'false' to add the full domain SAN to the site’s SSL certificate. Default value: true",
Type: schema.TypeBool,
Optional: true,
Default: "true",
Default: true,
},
// Computed Attributes
"site_creation_date": {
Expand Down
1 change: 1 addition & 0 deletions incapsula/resource_site_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ func testAccCheckIncapsulaSiteConfigBasic(domain string) string {
return fmt.Sprintf(`
resource "incapsula_site" "testacc-terraform-site" {
domain = "%s"
domain_validation = "cname"
}`,
domain,
)
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/site.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ The following arguments are supported:
* `logs_account_id` - (Optional) Account where logs should be stored. Available only for Enterprise Plan customers that purchased the Logs Integration SKU. Numeric identifier of the account that purchased the logs integration SKU and which collects the logs. If not specified, operation will be performed on the account identified by the authentication parameters.
* `active` - (Optional) Whether the site is active or bypassed by the Imperva network. Options are `active` and `bypass`.
* `restricted_cname_reuse` - (Optional) Use this option to allow Imperva to detect and add domains that are using the Imperva-provided CNAME (not recommended). One of: true | false.
* `domain_validation` - (Optional) Sets the domain validation method that will be used to generate an SSL certificate. Options are `email`, `html`, and `dns`.
* `domain_validation` - (Optional) Sets the domain validation method that will be used to generate an SSL certificate. Options are `email`, `html`, `cname` and `dns`.
* `approver` - (Optional) Sets the approver e-mail address that will be used to perform SSL domain validation.
* `ignore_ssl` - (Optional) Sets the ignore SSL flag (if the site is in pending-select-approver state). Pass "true" or empty string in the value parameter.
* `acceleration_level` - (Optional) Sets the acceleration level of the site. Options are `none`, `standard`, and `aggressive`.
Expand Down