Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows messages with empty "aps" property. #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcbertin
Copy link

@jcbertin jcbertin commented Feb 4, 2014

While playing around with MDM service and ApnsPHP, I notice that mdmd daemon on the supervised device is not happy with empty "aps" property.
BTW, the APNS documentation says that the "aps" is reserved but not mandatory: in fact, MDM service doesn't need it at all. And omitting the empty dictionary can save few bytes which can become big when you manage thousands of devices.
So I propose this patch to allow messages with no "aps" property.

Regards.

@jcbertin
Copy link
Author

jcbertin commented Jul 1, 2014

Furthermore, the MDM documentation (page 20) explains that "There should not be an aps key. (The aps key is used only for third-party app push notifications.)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant