refactor(server): auth route metadata #9344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
2b186e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ddb00826.immich.pages.dev |
| Branch Preview URL: | https://refactor-auth-route-metadata.immich.pages.dev |
danieldietzler
approved these changes
May 9, 2024
|
|
||
| if (options.isShared) { | ||
| decorators.push(SharedLinkRoute()); | ||
| if ((options as SharedLinkRoute)?.sharedLink) { |
There was a problem hiding this comment.
This isn't pretty lol. I feel like checking the type first would be cleaner
There was a problem hiding this comment.
Maybe we could add an isSharedRoute method or something that basically has the type (options: AuthenticatedOptions) options is SharedLinkRoute => boolean? (and then a similar thing for AdminRoute)
There was a problem hiding this comment.
This is the only place it is used though.
There was a problem hiding this comment.
There is no way to check the type besides doing exactly this.
There was a problem hiding this comment.
Oh because it's just a type, yeah you're right. It is used a couple of lines below as well though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedLinkRoute,PublicRoute, andAdminRouteinto a singleAuthenticateddecoratorAuthenticatedto be applied per route in preparation for fine-grained permissions