-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mobile): entities and models #9182
Conversation
Deploying immich with Cloudflare Pages
|
Bit of a drive-by, but should this include a change to the model_template and corresponding block in the README? |
@avidal Makes sense, we are still working on restructuring that so potentially that template might be gone as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the server we got rid of the domain folder. Having something similar in mobile might be nice as well. Maybe just folders for entities, services, models, interfaces, and repositories would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asset_viewer/image_providers
could be a top-level module.home/ui/asset_grid
could just be a top-level module ofasset_grid
.- I'm not a fan of the
shared
module, but it was there before so this doesn't need to address that now. I only bring it up in case others have better ideas what to do with it. ui
andview
sort of mean the same thing to me when I look at the modules. It seems likeui
is made up of composible Widget components whileview
is made up of pages of the application which compose from theui
. Maybe we can renameview
topage
?
Thank you for making this massive improvement! It was long overdue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can live in backup/services
Looking forward to the restructured code base! I agree with @jrasm91, instead of another level of nesting (domain), let us directly have folders for entities, models, ... one level higher up. Also agree with @martyfuhry, but we can do these changes in another PR. |
A lot of web projects use a |
entities
models