-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): email notifications #8447
Conversation
This adapter render the React-Email into HTML and plain/text email. The output is set as the body of the email.
Allow to use the NestJS-modules-mailer module to send SMTP emails. This is the base transport for the `NotificationRepository`
This allows to queue email sending jobs for the `EmailService`.
This act as a middleware to properly route the notification to the right transport. As POC I've only implemented a simple SMTP transport.
…ice` This trigger an event for the `NotificationRepository` that once processes by using the global config and per-user config will carry the payload to the right notification transport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library we're using will automatically upgrade to smtps if the mail server indicates it support the STARTTLS extension. |
This feels prone to breakage or MITM attacks. Is there a way to enforce it, something like a toggle to reject plaintext connections or such? |
Yes there is. So maybe enable that by default and have a toggle that optionally allows for insecure connections? |
FWIW it seems nextcloud does the same thing, there option is None/STARTTLS, so presumably they also auto upgrade |
I would be happy if we could add documentation to this. |
npm run email:dev
in the server directory. This just ned the dependencies to be installed and does not require the full server to be running.POST
request to/user
endpoint.Known issues:
Screenshots
Admin settings
Create user form
Welcome email template