fix(mobile): Multipart image loading for iOS double swipe #7064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyfuhry
changed the title
fyfrey
reviewed
Feb 12, 2024
| // TODO: Use local preview | ||
| // Load a small thumbnail | ||
| final thumbBytes = await asset.local?.thumbnailDataWithSize( | ||
| const ThumbnailSize.square(2000), |
There was a problem hiding this comment.
If we reuse the identical settings (default) add for thumbs on the grid, this will share the cached image because it's identical and super fast (already loaded for the grid view...)
Otherwise if this is too small: at least make the dimensions multiples of 16 (image codecs usually work in batches of 8x8 or 16x16) and set the quality to 80 (100 wastes a lot of space for almost identical visual quality as photo manager stores these thumbnails on the device)
There was a problem hiding this comment.
How does 256 with 80 quality sound?
There was a problem hiding this comment.
Perfect to me. However... The default is 250? for dumb reasons. So, we should optimally stick to whatever is currently specified in ImmichImage class
fyfrey
reviewed
Feb 12, 2024
| quality: 100, | ||
| ); | ||
| if (thumbBytes == null) { | ||
| throw StateError("Loading thumb for ${asset.fileName} failed"); |
There was a problem hiding this comment.
No need to error. We can simply try the original still..?
… out on thumbnail
Deploying with
|
| Latest commit: |
6438d51
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://160d5149.immich.pages.dev |
| Branch Preview URL: | https://fix-ios-double-swipe.immich.pages.dev |
fyfrey
approved these changes
Feb 12, 2024
alextran1502
merged commit ea293df
into
refactor/immich-image-provider
16 checks passed
alextran1502
added a commit
that referenced
this pull request
Feb 13, 2024
* Adds image provider * uses image provider * wip load preview * wip everything but activity asset thumbnail needs some help with a remote id * Immich provider used in gallery * First draft of the immich image provider, working nicely! * Removed OriginalImageProvider * Fixes for thumbnails * feat(mobile): thumbhash support (#7028) * feat(mobile): thumbhash support * perf(mobile): store bmp thumbhash bytes in Isar --------- Co-authored-by: shenlong-tanwen <[email protected]> * Uses octoimage for fade in and placeholders * fixes thumbnails, removes unused values, adds better thumbnail size * removes thumbhash support for now * Forgot one thumbhash removal * Use big thumbnail for local image on ios * fix(mobile): Multipart image loading for iOS double swipe (#7064) * uses local thumb first * Multipart thumbnail * Clean up file delete * await file delete * Fynn's comments, made thumbnail smaller and doesn't crash on erroring out on thumbnail * lint --------- Co-authored-by: Marty Fuhry <[email protected]> Co-authored-by: Alex <[email protected]> * Moves http client to global private place for reuse * Got rid of usePreview for local image providers since we always show a thumbnail anyway first * linter --------- Co-authored-by: shenlong <[email protected]> Co-authored-by: shenlong-tanwen <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Marty Fuhry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.