Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Admin Settings banner/scrolling issue #6839

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

azroberts8
Copy link
Contributor

@azroberts8 azroberts8 commented Feb 1, 2024

This pull request fixes #6809

Screen.Recording.2024-02-01.at.12.09.20.PM.mov

Video shows that scrolling only affects the list of settings and that the settings page does not overflow the screen when config warning is present

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 enabled auto-merge (squash) February 1, 2024 21:05
@alextran1502 alextran1502 merged commit 606147b into immich-app:main Feb 1, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Admin Settings banner/scrolling issue
3 participants