Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): Memories activity is now full screen, better image fit, adds progress indicator #6793

Merged
merged 12 commits into from
Feb 5, 2024

Conversation

martyfuhry
Copy link
Contributor

@martyfuhry martyfuhry commented Jan 31, 2024

image

  • Similar to the full-screen activity view of the gallery page, this will hide the system navigation bars when you enter the memories activity.
  • The navigation bars will return when you leave the activity.
  • Adds a progress bar at the top which animates along with the page moving
  • Computes aspect ratio of the photo and the available space; if the aspect ratios are nearly identical, then use much better looking BoxFit.cover image fit
  • Removes the "1|12" text in the top right
  • Refactors the widget to use more page controllers
  • Changed the close icon to have a little more contrast
  • Close icon now stays in the same place during page transitions

Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ae303a
Status:⚡️  Build in progress...

View logs

@martyfuhry martyfuhry changed the title feat(mobile): Memories activity is now full screen and hides the system navigation bars feat(mobile): Memories activity is now full screen, better image fit, adds progress indicator Jan 31, 2024
@martyfuhry
Copy link
Contributor Author

Ah, shoot I gotta dispose those PageController objects. But this is a HookConsumerWidget so I don't have a dispose method. Hold on while I fix that.

@martyfuhry
Copy link
Contributor Author

OK, I'm back to using Flutter Hooks once more. This is working fine and ready for review!

@martyfuhry
Copy link
Contributor Author

The latest commit adds ticks to the progress bar:

image

I'd love to get some kind of autoplay working, but it's proven a bit more challenging than I'd like for this PR. So I'll open a new one for that later.

@martyfuhry
Copy link
Contributor Author

With rounded edges:

image

@alextran1502 alextran1502 enabled auto-merge (squash) February 5, 2024 19:09
@alextran1502 alextran1502 merged commit c29976c into main Feb 5, 2024
23 of 24 checks passed
@alextran1502 alextran1502 deleted the feat/memories-fullscreen branch February 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants