Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): ffprobe not found #3532

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix(server): ffprobe not found #3532

merged 3 commits into from
Aug 3, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Aug 3, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 0:36am

@mertalev
Copy link
Contributor

mertalev commented Aug 3, 2023

Ah, the Dockerfile only adds ffmpeg to PATH in prod. This approach is also fine though, so I think you can remove the PATH line if you stick with linking in the script.

@jrasm91
Copy link
Contributor Author

jrasm91 commented Aug 3, 2023

Ah, the Dockerfile only adds ffmpeg to PATH in prod. This approach is also fine though, so I think you can remove the PATH line if you stick with linking in the script.

I was wondering how you were doing that. I forgot you only run prod builds. I'm good either way and didn't think to check the Dockerfile.

I'm afk for a bit so feel free to push the changes yourself if you want.

@alextran1502 alextran1502 merged commit a405fba into main Aug 3, 2023
20 checks passed
@alextran1502 alextran1502 deleted the fix/ffprobe-not-found branch August 3, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants