-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): ✨ Rounded corners on selected assets #3524
feat(web): ✨ Rounded corners on selected assets #3524
Conversation
Add rounded corner on selected items and fix circle icon transparent background on selection
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@@ -96,7 +96,9 @@ | |||
{#if disabled} | |||
<CheckCircle size="24" class="text-zinc-800" /> | |||
{:else if selected} | |||
<CheckCircle size="24" class="text-immich-primary" /> | |||
<div class="bg-[#D9DCEF] dark:bg-[#232932] rounded-full"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not proud of this part. At firt, I thought to use bg-immich-primary/20
and dark:bg-immich-dark-primary/20
but since the opacity is not 100%, we can still see the thumbnail through the cicle icon. If there's a better solution, I would be glad to update this part.
Thank you for the contribution, I like this a lot. The same implementation also just got merged on the mobile app a couple of days back. Can you help run |
I'm glad you like it. I saw the PR for the mobile app a few days ago. I was also working to make the same change for the mobile but the other dev was quicker than me 😄. It will look more consistent between the mobile and web app. |
I'm not a web developer but I love Immich (thanks a lot by the way) and would be glad to help.
Do not hesitate if I've done things wrong.
Changes