feat(mobile): auto close memories on scrolling beyond first / last memory

[shenlong-tanwen]

Changes made

• Scroll Physics for Android in Memory lane is made similar to the one used in iOS. It looks visually better and also fixes the jarring animation when a user tries to scroll past the last asset / memory.
• When a user tries to scroll above the first memory or scroll past the last memory, the memory lane is closed and the user is brought back to the timeline view. The same behavior is used if the user tries to scroll to the previous asset from the very first asset of the first memory or if a user tries to scroll past the last asset of the last memory

Before	After
Before-C.mp4	After-C.mp4

How Has This Been Tested?

• Made sure that the scrolling physics is used for both horizontal and vertical scrolls in Single asset memory as well as Multi asset memories
• Made sure that the user is brought back to the timeline view only when scrolling past the first and last memory. Scrolling in all the other memories takes the user to the previous or next asset accordingly

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
immich	⬜️ Ignored (Inspect)			Jul 31, 2023 3:40am

[shenlong-tanwen]

Returning back to the timeline if a user goes beyond the last assest of the last memory seems normal. I'm not entirely sure if having the Vertical OverScroll handling for popping out of Memory lane if a user scrolls above or below the first / last memory is intuitive. Seems normal to me, but others might feel different.

Returning back to timeline if a user scrolls to the left from the first asset of the first memory might also seem weird to few.

Should we keep all four handling. i.e, Returning back to timeline if a user tries one of the following:

• Scrolls to the left of first asset of the first memory
• Scrolls above the first memory
• Scrolls beyond the last memory
• Scrolls to the right of the last asset of the last memory

Or should we only keep the last one and remove the handling for the other 3 scenarios?

[alextran1502]

@shalong-tanwen Hey man, thank you for your high-quality contribution. I think we should only return to the timeline in two scenarios.

1. When the user clicks the exit button on the top left corner of any memories
2. When the user reach the last memory of the last memory lane

What do you think?

And by the way, do you have a Discord handler?

[shenlong-tanwen]

What do you think?

Yeah that might be the most natural behavior and the only one most users would've expected. I've changed it now to handle only OverScroll on the last asset of the last memory

And by the way, do you have a Discord handler?

Yes, I do. You can contact me @ _osorin