[ Mobile ] Fixed mobile app not reporting webm MIME type #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a small BUG with the mobile app's `webm` handling logic. Specifically, the app seems to correctly brows, play back, and attempt to upload `webm` files to the server. However, it seems to not correctly set the MIME type on the upload request resulting in the server rejecting it. The fix here seems to be pretty straight forward as we just need to add a case statement to the file name -> mime type handling logic. As per Mozilla's guide on MIME types, we always set `.webm`s to be `video/webm`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a small BUG with the mobile app's
webmhandling logic. Specifically, the app seems to correctly brows, play back, and attempt to uploadwebmfiles to the server. However, it seems to not correctly set the MIME type on the upload request resulting in the server rejecting it.The fix here seems to be pretty straight forward as we just need to add a case statement to the file name -> mime type handling logic. As per Mozilla's guide on MIME types, we always set
.webms to bevideo/webm.No changes need to be done on the server as Webm support seems to have merged as of #1365.
This PR closes #2086
This change was tested on my personal android 13 device and seems to have worked as the app is now able to upload
webmfiles to the server with no errors.