Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): improve and refactor thumbnails #2087

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Conversation

michelheusschen
Copy link
Contributor

The following changes are made:

  • Shrink the whole thumbnail when selected, except for the select button
  • Improved animation when selecting thumbnail
  • Allow video playback while the thumbnail is selected
  • Provide methods on the API class for getting file and thumbnail URLs
  • Show error icon when video loading fails
  • Live photos would only play when hovering the top right icon, now plays when hovering anywhere (same as video)

And the following bugs are fixes:

Currently there's some detection for horizontal and vertical asset orientation and sets the height/width accordingly. But I don't think exif data is actually present in a lot of cases and I'm not certain orientations like Rotate 90 CW are valid. Anyway, that still needs to be looked into further, but that's probably for a future PR.

@vercel
Copy link

vercel bot commented Mar 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
immich ⬜️ Ignored (Inspect) Mar 26, 2023 at 0:41AM (UTC)

@alextran1502
Copy link
Contributor

Live photos would only play when hovering the top right icon, now plays when hovering anywhere (same as video)

This is the intended behavior for LivePhoto to play when hover on the icon

@michelheusschen
Copy link
Contributor Author

Live photos would only play when hovering the top right icon, now plays when hovering anywhere (same as video)

This is the intended behavior for LivePhoto to play when hover on the icon

I understand, that's why I noted it as a change rather than a fix. Hovering over the icon to start playing live photos feels unintuitive to me, that's why I changed it. If you want however, it can be reverted.

@alextran1502
Copy link
Contributor

Live photos would only play when hovering the top right icon, now plays when hovering anywhere (same as video)

This is the intended behavior for LivePhoto to play when hover on the icon

I understand, that's why I noted it as a change rather than a fix. Hovering over the icon to start playing live photos feels unintuitive to me, that's why I changed it. If you want however, it can be reverted.

Yes please, I would like to treat it as a normal photo, the motion part is extra and only run when you specifically want to

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alextran1502 alextran1502 merged commit 4e526df into main Mar 27, 2023
@alextran1502 alextran1502 deleted the feat/web-asset-thumbnail branch March 27, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants