feat(web): improve and refactor thumbnails #2087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are made:
And the following bugs are fixes:
0:5
instead of0:05
Currently there's some detection for horizontal and vertical asset orientation and sets the height/width accordingly. But I don't think exif data is actually present in a lot of cases and I'm not certain orientations like
Rotate 90 CW
are valid. Anyway, that still needs to be looked into further, but that's probably for a future PR.