refactor(server): asset serve files #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jrasm91
force-pushed
the
refactor/asset-serve-files
branch
from
7e67394
to
6c29abc
Compare
| @@ -264,81 +247,18 @@ export class AssetService { | |||
| res: Res, | |||
| headers: Record<string, string>, | |||
| ) { | |||
| const allowOriginalFile = !authUser.isPublicUser || authUser.isAllowDownload; | |||
| const allowOriginalFile = !!(!authUser.isPublicUser || authUser.isAllowDownload); | |||
There was a problem hiding this comment.
What is the different between the old vs the new logic here?
There was a problem hiding this comment.
The old logic resulted in a type of boolean | undefined. That is OK because undefined also is falsy. However, it's now being passed into a function that has a type boolean, so this (!!) is just a fancy way to turn undefined into false.
There was a problem hiding this comment.
No change in logic, just a coercion of type to align with the new method I added.
alextran1502
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of duplicate code related to reading and returning a file (etag check, file readability check, setting headers, creating read stream, etc.). This has been refactored so there's no more duplicate code related to reading and streaming files.